RFR (round2) JDK-8038654: Separate SymbolTable and StringTable code

[Vladimir Kozlov]

In general looks fine.

In new files stringTable.?pp copyright year should be simple 2014.

Thanks,
Vladimir

On 5/5/14 8:32 AM, Gerard Ziemski wrote:
> Thank you for the review!
>
> May I ask for one more review from someone please?
>
>
> cheers
>
> On 5/5/2014 3:00 AM, Stefan Karlsson wrote:
>>
>> On 2014-05-02 18:57, Gerard Ziemski wrote:
>>> hi all,
>>>
>>> Please review this simple enhancement, which refactors symbolTable
>>> into symbolTable and stringTable
>>>
>>> The changes since rev0:
>>>
>>> Re: Stefan Karlsson
>>>
>>> - sorted includes
>>> - replaced "#include symbolTable.hpp" with just "#include
>>> stringTable.hpp" as needed
>>> - stringTable.cpp no longer includes symbolTable.hpp
>>> - stringTable.hpp forward declares Symbol instead of including
>>> symbolTable.hpp
>>>
>>>
>>> Webrev: http://cr.openjdk.java.net/~gziemski/8038654_rev1
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8038654
>>>
>>> Tested with hotspot jtreg, vm.quicklooks and JPRT. Locally builds on
>>> Mac OS X and Linux.
>>
>> Looks good to me. Thanks!
>>
>> Could you try to compile without precompiled headers? You can do this
>> by passing USE_PRECOMPILED_HEADER=0 to make.
>>
>> StefanK
>>
>>>
>>> Thank you.
>>>
>>>
>>>
>>>
>>
>>
>