RFR (round2) JDK-8038654: Separate SymbolTable and StringTable code

[Gerard Ziemski]

On 5/6/2014 9:17 AM, Coleen Phillimore wrote:
>
> On 5/6/14, 4:27 AM, Stefan Karlsson wrote:
>>
>> On 2014-05-05 23:07, Coleen Phillimore wrote:
>>>
>>> Hi,
>>>
>>> I don't see how this compiles without precompiled headers without 
>>> including symbolTable.hpp - there are files with 
>>> SymbolTable::unlink() so it must be included transitively (but I 
>>> haven't found which file indirectly includes it yet).
>>
>> I took a look at the include tree for 
>> concurrentMarkSweepGeneration.cpp (by passing -H to gcc), and 
>> apparently classFileParser.hpp includes symbolTable.hpp.
> Thanks for figuring it out Stefan.  I should remember the gcc -H option.
>
> It doesn't look like classFileParser.hpp _should_ include 
> symbolTable.hpp.
>>
>>> I think it's better not to include symbolTable.hpp transitively but 
>>> to include it directly in the files that use functions in 
>>> SymbolTable, ie all the GC files use SymbolTable::unlink.
>>
>> I agree with Coleen. Thanks for catching this.
>
> Sorry Gerard for not bringing this up sooner.

No worries. Thank you for such careful reviews - I prefer to get it just 
right.


cheers