RFR (round2) JDK-8038654: Separate SymbolTable and StringTable code
coleen.phillimore at oracle.com
Wed May 7 17:39:15 UTC 2014
On 5/7/14, 12:42 PM, Gerard Ziemski wrote:
> On 5/6/2014 9:17 AM, Coleen Phillimore wrote:
>> On 5/6/14, 4:27 AM, Stefan Karlsson wrote:
>>> On 2014-05-05 23:07, Coleen Phillimore wrote:
>>>> I don't see how this compiles without precompiled headers without
>>>> including symbolTable.hpp - there are files with
>>>> SymbolTable::unlink() so it must be included transitively (but I
>>>> haven't found which file indirectly includes it yet).
>>> I took a look at the include tree for
>>> concurrentMarkSweepGeneration.cpp (by passing -H to gcc), and
>>> apparently classFileParser.hpp includes symbolTable.hpp.
>> Thanks for figuring it out Stefan. I should remember the gcc -H option.
>> It doesn't look like classFileParser.hpp _should_ include
> Unfortunately classFileParses.hpp defines APIs using TempNewSymbol& so
> the include is required - forward declaring class TempNewSymbol did
> not work here.
Okay. Ship it!
More information about the hotspot-runtime-dev