RFR JDK-8040292: The verifier does not check that some annotation attributes are illegally specified more than once
Lois Foltan
lois.foltan at oracle.com
Mon May 12 13:17:38 UTC 2014
Hi Harold,
Looks good, but I do agree with Coleen's comment that this code needs
refactoring.
Lois
On 4/23/2014 7:00 PM, Coleen Phillimore wrote:
>
> This change looks good. I think this code needs to be refactored
> longer term.
> Coleen
>
> On 4/22/14, 9:21 AM, harold seigel wrote:
>> Hi,
>>
>> Please review this relatively small JDK-9 fix for bug JDK-8040292.
>> The JVM Specification states that there can only be one instance of
>> certain attributes. The VM checked this for some, but not all
>> cases. This fix adds the missing checks.
>>
>> Open webrev: http://cr.openjdk.java.net/~hseigel/bug_8040292_9/
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8040292
>>
>> The fix was tested with the Hotspot JTREG tests, JCK Lang tests, nsk
>> Quick tests, and the test case in this webrev.
>>
>> Thanks! Harold
>
More information about the hotspot-runtime-dev
mailing list