RFR(S): JDK-8025580 Temporary flags: UseNewReflection and ReflectionWrapResolutionErrors

[Yuri Gaevsky]

Thanks Coleen.

-Yuri


-----Original Message-----
From: Coleen Phillimore [mailto:coleen.phillimore at oracle.com] 
Sent: Tuesday, May 13, 2014 6:24 PM
To: Yuri Gaevsky; hotspot-runtime-dev at openjdk.java.net
Subject: Re: RFR(S): JDK-8025580 Temporary flags: UseNewReflection and ReflectionWrapResolutionErrors


Hi Yuri,

I had a scare that this VerifyReflectionBytecodes was actually useful 
but resolved that it is misleading at best.
We need one more reviewer for this change.

Thanks!
Coleen

On 5/12/14, 2:46 PM, Yuri Gaevsky wrote:
> Hi Coleen,
>
> Thanks for your quick review and sponsorship! The updated webrev is available at:
>    http://htmlpreview.github.io/?https://raw.github.com/ygaevsky/openjdk/master/8025580.1/index.html
>    https://github.com/ygaevsky/openjdk/blob/master/8025580.1/hotspot.patch
>
> [Tested by JCK-runtime-8 testrun on Windows]
>
> Best regards,
> -Yuri
>
>
> -----Original Message-----
> From: hotspot-runtime-dev [mailto:hotspot-runtime-dev-bounces at openjdk.java.net] On Behalf Of Coleen Phillimore
> Sent: Monday, May 12, 2014 7:52 PM
> To: hotspot-runtime-dev at openjdk.java.net
> Subject: Re: RFR(S): JDK-8025580 Temporary flags: UseNewReflection and ReflectionWrapResolutionErrors
>
>
> Hi Yuri,
>
> This change looks good.   I will sponsor it.  Could you also remove the
> VerifyReflectionBytecodes flag and add it to the obsolete list? Since
> you are very close to that code and that was also identified as a flag
> we'd like to remove in the bug?
>
> Thanks,
> Coleen
>
> On 5/12/14, 11:20 AM, Yuri Gaevsky wrote:
>> Hello.
>>
>> I am looking for a sponsor to review and to integrate this fix into JDK 9.
>>
>> Webrev:
>>     http://htmlpreview.github.io/?https://raw.github.com/ygaevsky/openjdk/master/8025580/index.html
>>     -or-
>>     https://github.com/ygaevsky/openjdk/blob/master/8025580/hotspot.patch
>>
>> Bug:
>>     https://bugs.openjdk.java.net/browse/JDK-8025580
>>
>> Summary:
>>     The fix removes all UseNewReflection/ReflectionWrapResolutionErrors occurrences/logic
>>     and adds them into the list of obsolete_jvm_flags in arguments.cpp.
>>
>> Tests:
>>     JCK-runtime-8 [api/java_lang & vm/] (Windows/Linux)
>>
>> Thanks,
>> -Yuri Gaevsky
>>
>