RFR (S) JDK-8043301: Duplicate definitions in vm/runtime/sharedRuntimeTrans.cpp versus math.h in VS2013

Lois Foltan lois.foltan at oracle.com
Wed May 21 19:12:47 UTC 2014


Thanks Coleen!
Lois

On 5/21/2014 2:27 PM, Coleen Phillimore wrote:
>
> Looks good, Lois.
> Coleen
>
> On 5/21/14, 10:41 AM, Lois Foltan wrote:
>> Hello,
>>
>> Please review the following fix:
>>
>> Webrev:
>>     http://cr.openjdk.java.net/~lfoltan/bug_jdk8043301/
>>
>> Bug: Duplicate definitions in vm/runtime/sharedRuntimeTrans.cpp 
>> versus math.h in VS2013
>>     https://bugs.openjdk.java.net/browse/JDK-8043301
>>
>> Summary of fix:
>> VS2013's include/math.h now contains definitions for both copysign() 
>> and scalbn().  This yielded compilation conflicts with the JVM's 
>> definition of these functions within runtime/sharedRuntimeTrans.cpp.  
>> I changed copysign and scalbn definitions to be consistent with how 
>> they are defined within sharedRuntimeTrig.cpp.  They are now defined 
>> as copysignA and scalbnA static functions.  I also removed the 
>> !defined(AIX) conditionalization around these defintions since no 
>> conflict should now exist with AIX's math.h.
>>
>> Tests:
>>     JPRT build & test, Hotspot jtreg, JDK lang & util, 
>> vm.quick.testlist (in progress)
>>
>> Thank you,
>> Lois
>



More information about the hotspot-runtime-dev mailing list