Request for review: JDK-8032970: stack size check methods for WhiteBox API

[Kirill Shirokov]

Hi Christian,

I agree -- that would be more consistent with existing naming. Fixed the 
metod name:
http://cr.openjdk.java.net/~iignatyev/kshirokov/8032970/webrev.05/

Regards,
Kirill

5/22/2014 2:52 AM, Christian Thalinger wrote:
> I’d prefer just WB_GetThreadStackSize.
>
> On May 21, 2014, at 1:57 PM, Kirill Shirokov 
> <kirill.shirokov at oracle.com <mailto:kirill.shirokov at oracle.com>> wrote:
>
>> WB_GetThreadFullStackSize returns value of JavaThread::stack_size(). 
>> Full here is used to denote 'Full' vs. 'Remaining'.
>>
>> 5/21/2014 9:04 PM, Christian Thalinger пишет:
>>> Quick question:  why is is called *WB_GetThreadFullStackSize*?  What 
>>> defines “full”?
>>>
>>> On May 21, 2014, at 7:28 AM, Kirill Shirokov 
>>> <kirill.shirokov at oracle.com <mailto:kirill.shirokov at oracle.com>> wrote:
>>>
>>>> Hi Vladimir,
>>>>
>>>> Thanks for reviewing. Please see the fixed diff:
>>>> http://cr.openjdk.java.net/~iignatyev/kshirokov/8032970/webrev.04/ 
>>>> <http://cr.openjdk.java.net/%7Eiignatyev/kshirokov/8032970/webrev.04/>
>>>>
>>>> I verified it with -Xint, -Xcomp and -Xmixed on all platforms (32- 
>>>> and 64-bit).
>>>>
>>>> Best regards,
>>>> Kirill
>>>>
>>>> 5/14/2014 10:56 PM, Vladimir Kozlov пишет:
>>>>> Thank you explanation, Kirill
>>>>>
>>>>> WBStackSize.java: please, use more descriptive names for variables:
>>>>>
>>>>> fss < tss * 0.9 || fss > tss
>>>>>
>>>>> You may want to run WBStackSize with -Xint. With compiled code 
>>>>> stack consumption is different. jtreg test could be run with 
>>>>> -Xcomp by harness (during Nightly), please, test such configurations.
>>>>>
>>>>> Thanks,
>>>>> Vladimir
>>>>>
>>>>> On 5/14/14 9:29 AM, Kirill Shirokov wrote:
>>>>>> Thanks to all reviewers!
>>>>>>
>>>>>> Could I ask to reivew the fixed patch:
>>>>>> http://cr.openjdk.java.net/~iignatyev/kshirokov/8032970/webrev.03/
>>>>>>
>>>>>> Bug report:
>>>>>> https://bugs.openjdk.java.net/browse/JDK-8032970
>>>>>>
>>>>>> The new functions will be used in the existing JSR292 tests -- we 
>>>>>> see a
>>>>>> lot of failures due to StackOverflowError.
>>>>>>
>>>>>> Best regards,
>>>>>> Kirill
>>>>>>
>>>>>> On 02/04/2014 10:03 PM, Vladimir Kozlov wrote:
>>>>>>> Kirill,
>>>>>>>
>>>>>>> You should include link to the bug report and add more explanation
>>>>>>> what this changes for. Will new functions be used in new or existing
>>>>>>> jsr292 tests?
>>>>>>>
>>>>>>> test/testlibrary_tests directory is used for classes used by other
>>>>>>> tests. I think you need to move new test WBStackSize.java into
>>>>>>> test/runtime directory.
>>>>>>>
>>>>>>> Thanks,
>>>>>>> Vladimir
>>>>>>>
>>>>>>> On 2/4/14 6:43 AM, Kirill Shirokov wrote:
>>>>>>>> Hi,
>>>>>>>>
>>>>>>>> Please review following webrev, which adds stack size checking 
>>>>>>>> methods
>>>>>>>> to WhiteBox API:
>>>>>>>>
>>>>>>>> http://cr.openjdk.java.net/~iignatyev/kshirokov/8032970/webrev.00/
>>>>>>>> <http://cr.openjdk.java.net/%7Eiignatyev/kshirokov/8032970/webrev.00/>
>>>>>>>>
>>>>>>>> Thank you,
>>>>>>>> Kirill
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>
>>>>
>>>
>>
>