RFR(XS): 8043896: Error reporting for insufficient shared region size is incorrect

[Yumin Qi]

Thanks for the review!

Yumin

On 5/27/2014 12:12 PM, Ioi Lam wrote:
> Looks good! Thanks Yumin.
>
> - Ioi
>
> On 5/27/14, 12:08 PM, Yumin Qi wrote:
>> Ioi and all,
>>
>>   I have updated the webrev at same URL,  have your comments please!
>>
>>   http://cr.openjdk.java.net/~minqi/8043896/
>>
>> Thanks
>> Yumin
>>
>> On 5/27/2014 9:49 AM, Yumin Qi wrote:
>>> Ioi,
>>>
>>>   Thanks for the review. There is no use for sure, but I could not 
>>> make sure the author's idea so added for it. I will remove the used 
>>> enum (newly added) and its related messages.
>>>
>>> Yumin
>>>
>>> On 5/27/2014 9:00 AM, Ioi Lam wrote:
>>>> Yumin,
>>>>
>>>> Looks like no one is calling report_out_of_shared_space to report 
>>>> "The native memory for metadata is not large enough". This seems to 
>>>> be vestige code. So instead of adding a new NativeMeta enum for 
>>>> SharedSpaceType, I think it's better to remove the unused array 
>>>> elements from report_out_of_shared_space().
>>>>
>>>> Thanks
>>>>
>>>> ./share/vm/memory/metaspaceShared.cpp: 
>>>> report_out_of_shared_space(SharedMiscData);
>>>> ./share/vm/memory/metaspaceShared.cpp: 
>>>> report_out_of_shared_space(SharedMiscData);
>>>> ./share/vm/memory/metaspace.cpp: 
>>>> report_out_of_shared_space(read_only ? SharedReadOnly : 
>>>> SharedReadWrite);
>>>> ./share/vm/classfile/classLoader.cpp: 
>>>> report_out_of_shared_space(SharedMiscData);
>>>> ./share/vm/classfile/classLoader.cpp: 
>>>> report_out_of_shared_space(SharedMiscData);
>>>> ./share/vm/utilities/debug.cpp:void 
>>>> report_out_of_shared_space(SharedSpaceType shared_space) {
>>>> ./share/vm/utilities/debug.hpp:void 
>>>> report_out_of_shared_space(SharedSpaceType space_type);
>>>> ./share/vm/utilities/hashtable.cpp: 
>>>> report_out_of_shared_space(SharedMiscData);
>>>> ./share/vm/utilities/hashtable.cpp: 
>>>> report_out_of_shared_space(SharedMiscData);
>>>>
>>>>
>>>>
>>>> On 5/23/14, 3:35 PM, Yumin Qi wrote:
>>>>> Please review:
>>>>>
>>>>> bug: https://bugs.openjdk.java.net/browse/JDK-8043896
>>>>> webrev: http://cr.openjdk.java.net/~minqi/8043896/
>>>>>
>>>>> Summary: In SharedSpaceType, we have three enum types which are 
>>>>> used in report_out_of_shared_space((SharedSpaceType type). In fact 
>>>>> we missed one which is corresponding to the first message and 
>>>>> flag. This leads the warning always gives wrong message for the 
>>>>> three types.
>>>>>
>>>>> Manually tested:
>>>>>
>>>>> -bash-4.1$ $J9/bin/java -XX:+UnlockDiagnosticVMOptions 
>>>>> -XX:SharedArchiveFile=./test.jsa -XX:SharedReadWriteSize=1M 
>>>>> -Xshare:dump
>>>>> Loading classes to share ... Java HotSpot(TM) 64-Bit Server VM 
>>>>> warning:
>>>>> The shared read write space is not large enough
>>>>> to preload requested classes. Use -XX:SharedReadWriteSize=
>>>>> to increase the initial size of shared read write space.
>>>>>
>>>>> -bash-4.1$ $J9/bin/java -XX:+UnlockDiagnosticVMOptions 
>>>>> -XX:SharedArchiveFile=./test.jsa -XX:SharedReadOnlySize=1M 
>>>>> -Xshare:dump
>>>>> Loading classes to share ... Java HotSpot(TM) 64-Bit Server VM 
>>>>> warning:
>>>>> The shared read only space is not large enough
>>>>> to preload requested classes. Use -XX:SharedReadOnlySize=
>>>>> to increase the initial size of shared read only space.
>>>>>
>>>>> -bash-4.1$ $J9/bin/java -XX:+UnlockDiagnosticVMOptions 
>>>>> -XX:SharedArchiveFile=./test.jsa -XX:SharedMiscDataSize=1M 
>>>>> -Xshare:dump
>>>>> Loading classes to share ... done.
>>>>> Rewriting and linking classes ... done.
>>>>> Number of classes 2465
>>>>> Calculating fingerprints ... done.
>>>>> Removing unshareable information ... done.
>>>>> Java HotSpot(TM) 64-Bit Server VM warning:
>>>>> The shared miscellaneous data space is not large enough
>>>>> to preload requested classes. Use -XX:SharedMiscDataSize=
>>>>> to increase the initial size of shared miscellaneous data space.
>>>>>
>>>>> JPRT in progress.
>>>>>
>>>>> Thanks
>>>>> Yumin
>>>>>
>>>>>
>>>>>
>>>>
>>>
>>
>