[9] RFR (XS) 8044339: wrong comment for FilterSpuriousWakeups option

[Igor Ignatyev]

Lev,

I've uploaded your webrev -- 
http://cr.openjdk.java.net/~iignatyev/lpriima/8044339/webrev.00/

there's other flags which have 'Solaris only', have you looked at them?
> $ cat ./src/share/vm/runtime/globals.hpp | grep -B2 "Solaris only"
>                                                                             \
>   product_pd(bool, DontYieldALot,                                           \
>           "Throw away obvious excess yield calls (for Solaris only)")       \
> --
>   product(bool, ConvertYieldToSleep, false,                                 \
>           "Convert yield to a sleep of MinSleepInterval to simulate Win32 " \
>           "behavior (Solaris only)")                                        \
>                                                                             \
>   product(bool, UseBoundThreads, true,                                      \
>           "Bind user level threads to kernel threads (for Solaris only)")   \
> --
>   develop(bool, UseDetachedThreads, true,                                   \
>           "Use detached threads that are recycled upon termination "        \
>           "(for Solaris only)")                                             \
> --
>   product(bool, UseAltSigs, false,                                          \
>           "Use alternate signals instead of SIGUSR1 & SIGUSR2 for VM "      \
>           "internal signals (Solaris only)")                                \
> --
>                                                                             \
>   product(bool, CompilerThreadHintNoPreempt, true,                          \
>           "(Solaris only) Give compiler threads an extra quanta")           \
>                                                                             \
>   product(bool, VMThreadHintNoPreempt, false,                               \
>           "(Solaris only) Give VM thread an extra quanta")                  \


Igor

On 05/29/2014 10:33 PM, Lev Priima wrote:
> Please review and help me with integration:
>
> diff -r 102506d9d873 src/share/vm/runtime/globals.hpp
> --- a/src/share/vm/runtime/globals.hpp    Wed May 28 14:42:00 2014 +0400
> +++ b/src/share/vm/runtime/globals.hpp    Thu May 29 22:29:37 2014 +0400
> @@ -1144,7 +1144,7 @@
> \
>     product(bool, FilterSpuriousWakeups,
> true,                                \
>             "Prevent spurious or premature wakeups from object.wait
> "         \
> -          "(Solaris
> only)")                                                 \
> +          "(Ignored for
> Windows)")                                          \
> \
>     product(intx, NativeMonitorTimeout, -1,
> "(Unstable)")                     \
> \
>
> bug: https://bugs.openjdk.java.net/browse/JDK-8044339
>