RFR(S): JDK-8044364: runtime/RedefineFinalizer test fails on windows

Daniel D. Daugherty daniel.daugherty at oracle.com
Fri May 30 20:58:02 UTC 2014


On 5/30/14 1:59 PM, Dmitry Samersoff wrote:
> Hi Everyone,
>
> http://cr.openjdk.java.net/~dsamersoff/JDK-8044364/webrev.01/
>
> I rewrote test launcher in java.
>
> Compilation left up to JTREG. So the test compiles with tools.jar from
> COMPILEJAVA but run with tools.jar from TESTJAVA - the same way as all
> other similar tests.
>
> -Dmitry
>

I was expecting pages and pages of Java code. :-) Guess not.

I'm fine with what you have here, but please make sure that
you test it on the usual nightly platforms. We don't want
another broken test in the nightly.

One question: any reason the test wasn't written using the
<jdk-repo>/test/java/lang/instrument testing support and
just use JLI's RedefineClass() function? Yes, I know that
means the test would be in the <jdk-repo> instead of the HotSpot
repo, but I don't know if anyone has added JLI testing
infrastructure to the <hotspot-repo>.

Dan



More information about the hotspot-runtime-dev mailing list