RFR 8058715: stability issues when being launched as an embedded JVM via JNI

[David Holmes]

On 6/11/2014 9:12 AM, David Holmes wrote:
> Hi David,
>
> On 6/11/2014 4:59 AM, david buck wrote:
>> Hi!
>>
>> This is a request for code review of my fix for jdk8058715
>>
>> BUGURL: https://bugs.openjdk.java.net/browse/JDK-8058715
>> WEBREV: http://cr.openjdk.java.net/~dbuck/8058715/webrev.01/
>>
>> We have also received confirmation from the original reporter of the
>> issue that this solution resolves the crashes they were seeing in their
>> environment. I have tested that this change does not break the original
>> NX bug workaround. I also ran the NX bug reproducer (v8 benchmark of
>> Nashorn running in a loop) using a fastdebug build with the
>> -XX:NativeMemoryTracking=summary option. Obviously no crashes or other
>> issues were detected.
>
> The failure mode for this suggests we are lacking something when we
> attempt to reserve memory. I think that needs closer examination as we
> should not have something that leads to silent corruption followed by
> spurious failures!
>
> That aside I don't see how this "does not break the original NX bug
> workaround". We will skip the workaround if the memory reservation
> fails. Is it the case that in such circumstances we don't need the
> workaround?

Sorry ignore this part. The original code was already bailing out if the 
reservation failed.

Thanks,
David


> Thanks,
> David H.
>
>> Cheers,
>> -Buck