RFR: JDK7 backport of 8020675 - invalid jar file in the bootclasspath could lead to jvm fatal error

[Andreas Eriksson]

Oh, interesting.
The hsx25 changeset does not display the dummy.jar as being a part of 
the checkin:
http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/7e7dd25666da

But when I navigate to the dummy.jar path I can see that it was checked 
in as part of that changeset:
http://hg.openjdk.java.net/hsx/hsx25/hotspot/log/7e7dd25666da/test/runtime/LoadClass/dummy.jar

Is this a know issue with mercurial?

Anyway, thanks for pointing this out, I would probably have missed it 
otherwise.
It seems that if the dummy.jar is not present the test always succeeds.

Thanks,
Andreas

On 2014-11-06 19:12, Calvin Cheung wrote:
> Hi Andreas,
>
> The change looks good.
> There should be a dummy.jar to go with the test cases.
> http://cr.openjdk.java.net/~ccheung/8020675/webrev.02/
>
> The webrev won't show any diffs for the jar file but don't forget to 
> include it when you push the fix.
>
> thanks,
> Calvin
>
> On 11/6/2014 8:38 AM, Andreas Eriksson wrote:
>> Hi,
>>
>> Could someone please review this jdk7 backport of JDK-8020675 
>> <https://bugs.openjdk.java.net/browse/JDK-8020675>.
>> Summary:
>> invalid jar file in the bootclasspath could lead to jvm fatal error
>> removed offending EXCEPTION_MARK calls and code cleanup
>>
>> One code change necessary for the backport was in method 
>> ClassLoader::load_classfile.
>> The change was to use CHECK_(instanceKlassHandle()) instead of 
>> CHECK_NULL.
>> See the mail thread at 
>> http://mail.openjdk.java.net/pipermail/hotspot-dev/2014-November/015825.html 
>> for more information.
>>
>> Webrev: http://cr.openjdk.java.net/~aeriksso/8020675/webrev.00/
>>
>> Regards,
>> Andreas
>>
>>
>