RFR (XS) JDK-8015272: Make @Contended within the same group to use the same oop map

Coleen Phillimore coleen.phillimore at oracle.com
Tue Nov 11 00:37:23 UTC 2014


Hi, I think this code looks correct.  Was there a test in the test 
system that exercises this code?  I think it would be hard to test with 
a dedicated test but was there one already in the test sets?

Secondly, could you use the word adjacent in the comments, reuse oopmap 
for adjacent oops in the class or something like that?  That would have 
saved me some jotting down on notebook.

I'll sponsor it if you get another reviewer.

Thanks,
Coleen


On 11/9/14, 10:49 AM, Aleksey Shipilev wrote:
> Hi again,
>
> No changes in webrev:
>   http://cr.openjdk.java.net/~shade/8015272/webrev.01/
>
> Please review and sponsor:
>   http://cr.openjdk.java.net/~shade/8015272/8015272.changeset
>
> As per Karen's request, more testing is done, ran the tests on my Linux
> x86_64/fastdebug:
>
> On 11/06/2014 07:07 PM, Aleksey Shipilev wrote:
>> On 11/06/2014 06:01 PM, Karen Kinnear wrote:
>>> - e.g. what about the vmtestbase vm/runtime/contended tests (and yes, some tests should be removed from that testlist)
> vmtestbase vm/runtime/contended: no issues.
> hotspot/test/runtime/ jtreg: no issues.
>
>>> - vmtestbase: vm.quick.testlist (required for runtime changes)
> vm.quick.testlist: no issues.
>
>>> - and since @Contended annotation is used in the JDK core libraries - the jtreg jdk tests?
> jdk/test/java/util/concurrent jtreg: no issues.
> jdk/test/java/lang/Thread jtreg: no issues.
>
>
> Thanks,
> -Aleksey.
>
>



More information about the hotspot-runtime-dev mailing list