RFR (XS) JDK-8015272: Make @Contended within the same group to use the same oop map
Coleen Phillimore
coleen.phillimore at oracle.com
Tue Nov 11 15:12:20 UTC 2014
On 11/11/14, 7:04 AM, Aleksey Shipilev wrote:
> On 11.11.2014 15:01, David Holmes wrote:
>>>> I'll sponsor it if you get another reviewer.
>> I'll add my Review. Changes seem okay.
> Thanks!
>
>> Looks like the style-Police didn't pay enough attention to this section
>> of code though as a lot of:
>>
>> if( XXX )
>>
>> have crept in instead of:
>>
>> if (XXX)
>>
>> ;-)
> Yes, but unfortunately, that is consistent with the code style in
> method. If we are to change that, we should probably need to change the
> style consistently in the entire classLoader.cpp.
I didn't notice that this was a copy. This code is badly in need of
refactoring to remove all the duplication, someday.
Coleen
>
> -Aleksey.
>
More information about the hotspot-runtime-dev
mailing list