[9] RFR (S) 6191224: (reflect) Misleading detail string in IllegalArgumentException thrown by Array.get<Type>

Chris Plummer chris.plummer at oracle.com
Thu Oct 9 00:07:39 UTC 2014


Hi,

Please review this cleanup of a misleading exception message.

Summary: The test case shows that an exception is thrown with the 
message "Argument is not an array", when in fact the argument is an 
array, but a primitive type array is actually what was expected. Fixed 
by differentiating between failing because an array was expected and 
failing because a primitive type array was expected.

Webrev: http://cr.openjdk.java.net/~cjplummer/6191224/webrev.00/
Bug: https://bugs.openjdk.java.net/browse/JDK-6191224

Tested with:
     jprt "-testset hotspot"
     JTReg with hotspot tests and some jdk tests
     JCK vm, lang, api
     vm.quick.testlist
     runthese

Output for the regression test when passing is:

2147483647
Test #1 PASSES
java.lang.IllegalArgumentException: Argument is not a primitive type array
Test #2 PASSES
java.lang.IllegalArgumentException: Argument is not an array
Test #3 PASSES

And when it fails:

2147483647
Test #1 PASSES
java.lang.IllegalArgumentException: Argument is not an array
Test #2 FAILS - incorrect message

thanks,

Chris



More information about the hotspot-runtime-dev mailing list