RFR 8060256: The loop in Arguments::parse() can be enhanced

[Jiangli Zhou]

Ok. Thanks David.

Jiangli

On 10/15/2014 06:29 PM, David Holmes wrote:
> On 16/10/2014 11:18 AM, Jiangli Zhou wrote:
>> Hi David,
>>
>> Thanks for the review.
>>
>> On 10/15/2014 06:11 PM, David Holmes wrote:
>>> Hi Jiangli,
>>>
>>> On 16/10/2014 9:20 AM, Jiangli Zhou wrote:
>>>> Hi,
>>>>
>>>> This enhancement was suggested by Bertrand during the review for
>>>> 8047934. The 'continue' statement can be added to the matching 
>>>> cases to
>>>> avoid the further checks after that.
>>>
>>> Stylistically I think these should be nested if/else but ...
>>>
>>>>
>>>>    http://cr.openjdk.java.net/~jiangli/8060256/webrev.00/
>>>>
>>>> Tested with jtreg hotspot/test/runtime/CommandLine tests, including 
>>>> the
>>>> new one being added. Also started JPRT, no failure so far.
>>>
>>> Not quite sure what the new test is actually testing. Regression tests
>>> are supposed to check that a specific failure condition no longer
>>> occurs. This is more a simple functional test.
>>
>> Right. I added the test just to make sure those arguments do not affect
>> the parsing of other options that come after them in the command line. I
>> can leave it out.
>
> No I think the requirement these days is "thou shalt add a test". I 
> guess I just need to stop referring to things in the test directory as 
> "regression tests" now.
>
> Thanks,
> David
>
>>> Anyway the test also needs:
>>>
>>> @build com.oracle.java.testlibrary.*
>>>
>>> to ensure testlibrary is built.
>>
>> Ok.
>>
>> Thanks,
>> Jiangli
>>
>>>
>>> Thanks,
>>> David
>>>
>>>> Thanks,
>>>> Jiangli
>>