RFR (XS) 8056971 - Minor class loading clean-up
Ioi Lam
ioi.lam at oracle.com
Mon Sep 1 03:02:23 UTC 2014
On 8/31/14, 3:34 PM, David Holmes wrote:
> Looks okay.
>
> src/share/vm/classfile/sharedPathsMiscInfo.cpp seems to have an empty
> set of changes
>
There was a deletion of a single space character in this file, but
webrev doesn't list the white-space-only changes ....
- Ioi
> Thanks,
> David
>
>
> On 1/09/2014 4:55 AM, Ioi Lam wrote:
>> Please review a very small fix:
>>
>> http://cr.openjdk.java.net/~iklam/8056971_classloader_cleanup/
>>
>> Bug: Minor class loading clean-up
>>
>> https://bugs.openjdk.java.net/browse/JDK-8056971
>>
>> Summary of fix:
>>
>> Code review after the push of JDK-8046070 (Class Data Sharing
>> cleanup and refactoring)
>> has found some minor issues:
>>
>> + Misplacement of #if INCLUE_CDS
>> + typos
>> + unnecessary C string duplication
>> -> in fixing this I converted a bunch of unnecessary
>> "char*" to "const char*"
>>
>> Tests:
>>
>> JPRT
>> UTE vm.quick.testlist, vm.parallel_class_loading.testlist
>>
>> Thanks
>> - Ioi
More information about the hotspot-runtime-dev
mailing list