RFR(S): 8057147 - [TESTBUG] Platform.isDebugBuild() doesn't work on all build types

[Karen Kinnear]

I would like to second doing this as a two step fix.

thanks,
Karen

On Sep 3, 2014, at 1:51 PM, Staffan Larsen wrote:

> I agree that the correct fix is a combination of Christian’s fix and a fix to the version strings on Windows. However, I would like to approve Christian’s fix first because this bug is currently preventing us from doing the switchover to full jdk builds (which I was hoping to complete next week). Is it an ok approach to fix this in two steps?
> 
> BTW: If you mix debug and product bits, or mix hotspot and jdk bits from different repos I don’t think we can guarantee that all testing will work as expected. 
> 
> Thanks,
> /Staffan
> 
> On 3 sep 2014, at 17:12, Daniel D. Daugherty <daniel.daugherty at oracle.com> wrote:
> 
>> I would think this should be fixed in the build system where the
>> VM bits are being improperly tagged. What Windows build config
>> is getting this wrong?
>> 
>> Also, it is possible to have:
>> 
>>   product JDK bits + debug JVM bits
>>   debug JDK bits + product JVM bits
>> 
>> as well as the other combinations. So just because you have
>> debug JDK bits, that does not mean you have to have debug
>> JVM bits.
>> 
>> Dan
>> 
>> 
>> On 9/3/14 9:01 AM, Christian Tornqvist wrote:
>>> Hi everyone,
>>> 
>>> 
>>> Small fix/workaround for an issue where Platform.isDebugBuild() fails to
>>> identify debug builds on certain build types. Seems like the VM version
>>> string is a bit different on Windows platforms depending on how it's built.
>>> 
>>> 
>>> Webrev:
>>> 
>>> http://cr.openjdk.java.net/~ctornqvi/webrev/8057147/webrev.00/
>>> 
>>> 
>>> Bug:
>>> 
>>> https://bugs.openjdk.java.net/browse/JDK-8057147
>>> 
>>> 
>>> Thanks,
>>> 
>>> Christian
>>> 
>>> 
>>> 
>>> 
>> 
>