RFR (S) 8057570: RedefineClasses() tests fail assert(((Metadata*)obj)->is_valid()) failed: obj ,is valid

[Coleen Phillimore]

On 9/4/14, 8:59 PM, Vladimir Kozlov wrote:
> On 9/4/14 5:44 PM, Coleen Phillimore wrote:
>> Summary: Revert two small changes from the previous-versions cleanup
>> with marking code cache.
>>
>> These weren't really related to the cleanup, but I thought they'd make
>> it more efficient.  One caused the crash and the other I'm just being
>> paranoid about.  Remind me to stay away from deoptimization.
>
> Which one causes the crash? The bug report does not have an 
> evaluation. It would be nice if you explain it here. What happened?

I added an evaluation to the bug which explains partially why it 
crashed.  There are some mysteries which maybe you know and could help with.

It was the change to nmethod::metadata_do that caused the crash. The 
other I backed out out of paranoia.  I should have said in the RFR.

>
> Changes looks fine.

Thanks!!
Coleen
>
> Thanks,
> Vladimir
>
>>
>> open webrev at http://cr.openjdk.java.net/~coleenp/8057570/
>> bug link https://bugs.openjdk.java.net/browse/JDK-8057570
>>
>> Tested with failing test case in loop on machine where it failed every
>> time.
>>
>> Coleen