RFR(XS): 8056930: Output host info under some condition for core dump

[Yumin Qi]

David,

   Thanks for the review.

On 9/7/2014 7:07 PM, David Holmes wrote:
> Hi Yumin,
>
> On 6/09/2014 7:46 AM, Yumin Qi wrote:
>> Please review
>>
>> Bug:  https://bugs.openjdk.java.net/browse/JDK-8056930
>> Webrev:  http://cr.openjdk.java.net/~minqi/8056930/webrev00
>
> The posix change seems fine as it adds nothing new to the process.
>
> However I have to wonder for the Windows fix whether GetComputerNameEx 
> will be callable in general when we are crashing? We already attempt 
> to do a lot of things in error reporting that can fail, so I guess 
> adding one more doesn't really change things - as long as it seems to 
> be working most of the time.
>
 From the test under crash, it shows callable, but the safe way is to 
check its return value.

Thanks
Yumin

> Thanks,
> David
>
>>    After java crashed, we would like to know the host on which it failed
>> especially when doing parallel testing on multiple machines. The most
>> useful for knowing host name is telling if the test is hardware related,
>> that the test can only repeat on it.   This piece of code help to print
>> out host name in debug mode.
>>
>>    Test: manually tested on Unix/Linux/Windows with
>> -XX:+CrashGCForDumpingJavaThread.
>>     JPRT
>>
>> Thanks
>> Yumin