RFR(XS): 8056930: Output host info under some condition for core dump

[Calvin Cheung]

Yumin,

os_windows.cpp

1592   char buffer[4096];

Why do you need a 4k buffer?

According to: 
http://msdn.microsoft.com/en-us/library/windows/desktop/ms724220(v=vs.85).aspx
"Each name can be up to 255 bytes total. "

So maybe 256 is sufficient?

btw, is your new webrev located at: 
http://cr.openjdk.java.net/~minqi/8056930/webrev01/ ?

thanks,
Calvin

On 9/8/2014 10:17 AM, Yumin Qi wrote:
> Hi,
>
>   I made a small change to Windows part, when GetComputerNameEx fails, 
> instead of do nothing, output "N/A".
>
> Thanks
> Yumin
>
> On 9/5/2014 2:46 PM, Yumin Qi wrote:
>> Please review
>>
>> Bug:  https://bugs.openjdk.java.net/browse/JDK-8056930
>> Webrev:  http://cr.openjdk.java.net/~minqi/8056930/webrev00
>>
>>   After java crashed, we would like to know the host on which it 
>> failed especially when doing parallel testing on multiple machines. 
>> The most useful for knowing host name is telling if the test is 
>> hardware related, that the test can only repeat on it. This piece of 
>> code help to print out host name in debug mode.
>>
>>   Test: manually tested on Unix/Linux/Windows with 
>> -XX:+CrashGCForDumpingJavaThread.
>>    JPRT
>>
>> Thanks
>> Yumin
>