RFR (L/XXS) cleanup indent white space issues (8057107)
serguei.spitsyn at oracle.com
serguei.spitsyn at oracle.com
Mon Sep 8 21:24:40 UTC 2014
The fix looks good and save. :)
Thanks,
Serguei
On 9/7/14 12:13 PM, Daniel D. Daugherty wrote:
> Greetings,
>
> I have the fix for the following bug ready for JDK9 RT_Baseline:
>
> JDK-8057107 cleanup indent white space issues prior to Contended
> Locking reorder and cache line bucket
> https://bugs.openjdk.java.net/browse/JDK-8057107
>
> This is both a (L)arge and e(X)tra e(X)tra (S)mall review! Here is the
> URL for the (L)arge webrev:
>
> http://cr.openjdk.java.net/~dcubed/8057107-webrev/0-jdk9-hs-rt/
>
> Since these are white space fixes, I recommend the udiff links instead
> of the frames links. Of course, some folks prefer the patch file itself
> for white space fixes.
>
> Here is the URL for the e(X)tra e(X)tra (S)mall webrev which was
> generated
> with a version of webrev that ignores all whitespace changes:
>
> http://cr.openjdk.java.net/~dcubed/8057107-webrev/0-jdk9-hs-rt-no_ws/
>
> Again, I recommend the udiff links since that's the fastest way to see
> that webrev_no_ws found no non-white space changes. The patch file for
> this webrev shows all the white space changes.
>
> These indent white space cleanups were done in preparation for the
> reorder
> and cache line bucket from the Contended Locking project; these changes
> were made by my do_all_line_filters.ksh script. The script does not fix
> everything in these files that is not in sync with HotSpot style, but it
> does fix a large portion of them.
>
> Thanks, in advance, for any comments, questions or suggestions.
>
> At the end of the review cycle for this fix, I will attach the version of
> the do_all_line_filters.ksh script and the line_indent_filter.java used
> to do the work to JDK-8057107.
>
> Dan
>
>
More information about the hotspot-runtime-dev
mailing list