(XS) RFR: 8056183: os::is_MP() always reports true when NMT is enabled
Aleksey Shipilev
aleksey.shipilev at oracle.com
Tue Sep 9 08:34:48 UTC 2014
On 09/09/2014 12:30 PM, David Holmes wrote:
> On 9/09/2014 6:25 PM, Aleksey Shipilev wrote:
>> On 09/09/2014 12:21 PM, David Holmes wrote:
>>> Updated webrev:
>>>
>>> http://cr.openjdk.java.net/~dholmes/8056183/webrev.v2/
>>
>> Looks good. Does it makes sense to merge the _processor_count checks? I
>> think it clearly tells what we consider an "MP" system:
>>
>> return (_processor_count != 1) || AssumeMP;
>
> As long as some micro-optimization geek doesn't jump on me for replacing
> a > check with a != :)
Wait, now I have second thoughts...
> http://cr.openjdk.java.net/~dholmes/8056183/webrev.v3/
Joking. This looks good. I would also put parentheses before pushing.
-Aleksey.
More information about the hotspot-runtime-dev
mailing list