RFR (XS) 8057925: PrintSymbolTableSizeHistogram prints misleading output

Gerard Ziemski gerard.ziemski at oracle.com
Wed Sep 17 20:44:55 UTC 2014


Thank you, looks great!

On 9/17/2014 2:34 PM, Aleksey Shipilev wrote:
> Hi Gerard,
>
> On 09/12/2014 07:57 PM, Gerard Ziemski wrote:
>> I was in the same position as you some time ago, confused and unclear
>> about what the histogram actually shows, so big thanks for fixing this
>> and please consider it reviewed (with small "r" though unfortunately)
>>
>> This is probably a personal preference, but since we're touching the
>> code, could perhaps clean up the formatting of the shown text a bit?
> Yes. See the update:
>    http://cr.openjdk.java.net/~shade/8057925/webrev.02/
>
> It now prints:
>
> Symbol Table Histogram:
>    Total number of symbols    23524
>    Total size in memory         861K
>    Total counted                  0
>    Total removed                  0
>    Reference counts           15503
>    Symbol arena used            803K
>    Symbol arena size            807K
>    Total symbol length       609902
>    Maximum symbol length       1316
>    Average symbol length      25.93
>    Symbol length histogram:
>      Length   #Symbols       Size
>           0          1          0K
>           1         71          1K
>           2        442          6K
>           3        478          7K
> ...
>          98         15          1K
>          99         13          1K
>    >=   100        492         74K
>
> Thanks,
> -Aleksey.
>



More information about the hotspot-runtime-dev mailing list