(XS) RFR: Add sanity test for minimal VM in test/Makefile

Coleen Phillimore coleen.phillimore at oracle.com
Tue Sep 23 19:57:19 UTC 2014


Yes, looks good to me too.
Coleen

On 9/23/14, 3:52 PM, Vladimir Kozlov wrote:
> Good.
>
> Vladimir K
>
> On 9/23/14 12:41 PM, David Holmes wrote:
>> On 24/09/2014 5:29 AM, Christian Thalinger wrote:
>>>
>>> On Sep 23, 2014, at 8:55 AM, David Holmes <david.holmes at oracle.com> 
>>> wrote:
>>>
>>>> On 24/09/2014 1:49 AM, Christian Thalinger wrote:
>>>>> Why are you duplicating servertest? Are you expecting servertest 
>>>>> or minimaltest to change?
>>>>
>>>> You mean I should just combine them into a single recipe? I could 
>>>> do that.
>>>
>>> Seems easier.
>>>
>>>> It seemed cleaner/clearer to keep them distinct. In theory they 
>>>> might do different things :) But I'm not bothered
>>>> either way.
>>>
>>> Yeah, either way is fine with me.
>>
>> Okay leaving as-is.
>>
>> Still need second reviewer for trivial change.
>>
>> Thanks,
>> David
>>
>>>>
>>>> Thanks,
>>>> David
>>>>
>>>>> On Sep 22, 2014, at 6:03 PM, David Holmes 
>>>>> <david.holmes at oracle.com> wrote:
>>>>>
>>>>>> https://bugs.openjdk.java.net/browse/JDK-8058919
>>>>>>
>>>>>> http://cr.openjdk.java.net/~dholmes/8058919/webrev/
>>>>>>
>>>>>> test/Makefile defines the simple sanity check tests: clienttest 
>>>>>> and servertest. To that we add minimaltest to test
>>>>>> the minimal VM.
>>>>>>
>>>>>> This will be used by our JPRT system to ensure there is no 
>>>>>> accidental breakage of the minimal VM.
>>>>>>
>>>>>> Thanks,
>>>>>> David
>>>>>>
>>>>>
>>>



More information about the hotspot-runtime-dev mailing list