RFR (s) 8057846: ClassVerifier::change_sig_to_verificationType temporary symbol creation code is, hot

Coleen Phillimore coleen.phillimore at oracle.com
Fri Sep 26 21:11:42 UTC 2014


Thanks for looking at this.  I'll fix the typo.  It's trying to get 
checked in now but I can stop it.
Thanks,
Coleen

On 9/26/14, 4:48 PM, Vitaly Davidovich wrote:
>
> Just lurking but there's a typo in
>
>   // This version just updates the reference count and saves the 
> symbol to be
> 417     // derefenced later.
>
> Should say "dereferenced later"?
>
> Sent from my phone
>
> On Sep 26, 2014 4:09 PM, "Coleen Phillimore" 
> <coleen.phillimore at oracle.com <mailto:coleen.phillimore at oracle.com>> 
> wrote:
>
>
>     Thank you, Harold, Lois and Aleksey.
>     Coleen
>
>     On 9/26/14, 2:56 PM, Aleksey Shipilev wrote:
>
>         On 09/26/2014 10:31 PM, Coleen Phillimore wrote:
>
>             Summary: Only update the refcount without looking it up in
>             the symbol
>             table.
>
>             open webrev at
>             http://cr.openjdk.java.net/~coleenp/8057846/
>             <http://cr.openjdk.java.net/%7Ecoleenp/8057846/>
>             bug link https://bugs.openjdk.java.net/browse/JDK-8057846
>
>         Looks good, thanks!
>
>             Ran regression tests (testbase, runtime jtreg).  Aleksey
>             verified
>             performance improvement.
>
>         Yes, for the record, it gives +5% improvement for class
>         loading time (as
>         measured on Nashorn generated classes).
>
>         -Aleksey.
>
>
>



More information about the hotspot-runtime-dev mailing list