RFR 8076492: Make common code from template interpreter code

Coleen Phillimore coleen.phillimore at oracle.com
Thu Apr 2 01:48:36 UTC 2015


On 4/1/15, 8:54 PM, David Holmes wrote:
> Hi Coleen,
>
> This all looks okay to me. The spacing in the header file is somewhat 
> inconsistent but ... :)

I moved

*+   static void    resolve_from_cache(JavaThread* thread, Bytecodes::Code bytecode);*


to

*+   static void resolve_from_cache(JavaThread* thread, Bytecodes::Code bytecode);*


So the resolve function spacing would be consistent with each other.  
Having all these functions line up but then wrap around my screen 
doesn't improve readability in my opinion.

thanks,
Coleen

>
> Thanks,
> David
>
> On 2/04/2015 3:24 AM, Coleen Phillimore wrote:
>> Summary: Move case statement out of assembly code
>>
>> Tested with JPRT for all (most) platforms - please verify AARCH64.
>> Also ran specjbb2005 with linux x64 - not a twitch in performance 
>> change.
>>
>> open webrev at http://cr.openjdk.java.net/~coleenp/8076492/
>> bug link https://bugs.openjdk.java.net/browse/JDK-8076492
>>
>> This code is helpful for some class redefinition improvements that I've
>> been prototyping.
>>
>> Thanks,
>> Coleen



More information about the hotspot-runtime-dev mailing list