RFR[ 9u-dev] JDK-8072863 - Replace fatal() with vm_exit_during_initialization() when an incorrect class is found on the bootclasspath

Coleen Phillimore coleen.phillimore at oracle.com
Thu Apr 2 17:10:37 UTC 2015


Yes, this still looks good to me.
Coleen

On 4/2/15, 11:33 AM, Jaroslav Bachorik wrote:
> Still good.
>
> -JB-
>
> On 2.4.2015 17:31, cheleswer sahu wrote:
>> Hi,
>>
>> Please review the new code changes. I have incorporated the suggestion
>> received from 'David Holmes'  in code and built successfully. As I do
>> not have account for OpenJDK, David Buck will push the fix into
>> jdk9/hs-rt/.
>> web review link: http://cr.openjdk.java.net/~dbuck/8072863/webrev.02/
>>
>> Regards,
>> Cheleswer
>>
>> On 3/30/2015 2:14 AM, David Holmes wrote:
>>> On 27/03/2015 5:36 PM, cheleswer sahu wrote:
>>>> Hi,
>>>> Please review the code changes for
>>>> https://bugs.openjdk.java.net/browse/JDK-8072863. I have built the 
>>>> JDK9
>>>> with fix successfully. As I do not have account for OpenJDK, David 
>>>> Buck
>>>> will push
>>>> the fix into jdk9/hs-rt/.
>>>>
>>>> Web review link: http://cr.openjdk.java.net/~dbuck/8072863/webrev.00/
>>>
>>> Is it possible to include information about where the class was loaded
>>> from in the message that precedes the exit:
>>>
>>>  121     tty->print_cr("Invalid layout of %s at %s",
>>> ik->external_name(), name_symbol->as_C_string());
>>>
>>> The main cause of this problem is android.jar on the bootclasspath. It
>>> would be good to make that explicit as well. Otherwise we will still
>>> get bug reports because noone will know what this error means.
>>>
>>> Thanks,
>>> David
>>>
>>>
>>>> Regards,
>>>> Cheleswer
>>>>
>>>>
>>>>
>>>>
>>
>



More information about the hotspot-runtime-dev mailing list