RFR [8u] (XS) JDK-8047382: hotspot build failed with gcc version Red Hat 4.4.6-4

Stefan Karlsson stefan.karlsson at oracle.com
Wed Apr 15 08:44:56 UTC 2015


Hi Lois,

On 2015-04-15 01:40, Lois Foltan wrote:
> Hello,
>
> Please review the following fix:
>
> Webrev:
>     http://cr.openjdk.java.net/~lfoltan/bug_jdk8047382/
>

Looks good to me.

Is there a reason why cast_from_oop<void *>(...) isn't used here?

Thanks,
StefanK

> Bug: hotspot build failed with gcc version Red Hat 4.4.6-4
>     https://bugs.openjdk.java.net/browse/JDK-8047382
>
> Summary of Fix:
> Removed the Solaris specific conditionalization for casting to void * 
> within calls to HS_DTRACE_PROBE* from DTRACE_CLASSINIT_PROBE* and 
> DTRACE_CLASSLOAD_PROBE macro definitions.  gcc 4.4.6-4 needs this cast 
> as well.  This only affects JDK 8u.  Thank you to Mario Torre for 
> providing the webrev fix for this issue.
>
> Tests:
>     jprt build submission to test compilation with all compilers
>     vm.quick.testlist, hotspot/test/*
>     Built and testing as well with a gcc 4.4.6-4 compiler (in progress)



More information about the hotspot-runtime-dev mailing list