(XS) RFR: 8077674: BSD build failures due to undefined macros

[Kim Barrett]

On Apr 16, 2015, at 1:25 AM, David Holmes <david.holmes at oracle.com> wrote:
> 
> Here's an alternate webrev based on Kim's findings in the other thread.
> 
> http://cr.openjdk.java.net/~dholmes/8077674/webrev.v2/
> 
> Basically #elif XXX is replaced with #else #ifdef XXX #endif". With lots of new lines of course.
> 
> I don't know what the normal style rules are for nesting preprocessing conditionals. I prefer to see the # lines indented, but I know people like to see the real code at the indent it would be if there were no conditional.

The webrev seems culturally compatible with other hotspot code I looked at.  A different style
is to have all the “#” be at the start of the line but indent the directive name to show nesting.
Both seem to exist in hotspot, though the latter seems less prevalent.

Looks good.  (Well, looks ugly, really, but passes muster for review purposes.)