RFR: 8077308: Fix warning: increase O_BUFLEN in ostream.hpp -- output truncated
David Holmes
david.holmes at oracle.com
Fri Apr 17 12:04:07 UTC 2015
Thanks Harold!
David
On 17/04/2015 10:00 PM, harold seigel wrote:
> The change looks good.
>
> Thanks, Harold
>
> On 4/17/2015 6:25 AM, David Holmes wrote:
>> Can we get a second reviewer please!
>>
>> Thanks,
>> David
>>
>> On 16/04/2015 5:48 PM, Andrew Haley wrote:
>>>
>>> On 16/04/15 03:41, David Holmes wrote:
>>>> On 15/04/2015 8:43 PM, Andrew Haley wrote:
>>>>> On 04/15/2015 03:36 AM, David Holmes wrote:
>>>>>> On 14/04/2015 10:54 PM, Andrew Haley wrote:
>>>>>>> http://cr.openjdk.java.net/~aph/8077308/
>>>>>>
>>>>>> Looks fine.
>>>>>>
>>>>>> Could you add a comment like:
>>>>>>
>>>>>> // print in two stages to avoid problems with long keys/values
>>>>>
>>>>> OK, here it is. You have to push it.
>>>>
>>>> Okay I can sponsor it :) But need a second reviewer.
>>>>
>>>>> http://cr.openjdk.java.net/~aph/8077308-1/
>>>>
>>>> This dragged in an unrelated change to
>>>> src/cpu/aarch64/vm/interp_masm_aarch64.hpp
>>>
>>> Oh, rats. I didn't realize that webrev would drag in changes that
>>> weren't
>>> committed. I have to use that patch or HotSpot won't build.
>>>
>>> http://cr.openjdk.java.net/~aph/8077308-2/
>>>
>>> Andrew.
>>>
>
More information about the hotspot-runtime-dev
mailing list