RFR(XS) 8025979: Write test to exercise uninitialized strings from JNI code

[David Simms]

Looks good

/David Simms (not a 'R'eviewer)

On 28/04/2015 4:10 p.m., Stas Smirnov wrote:
> Hi,
>
> one more update, start using FatalError to avoid extra checks and 
> return statements, please take a look
> webrev: http://cr.openjdk.java.net/~stsmirno/8025979/webrev.02/ 
> <http://cr.openjdk.java.net/%7Estsmirno/8025979/webrev.02/>
>
> I still need a sponsor for this fix, who can push it.
>
> On 23.04.2015 17:03, Stas Smirnov wrote:
>> Hello,
>>
>> here is an updated fix for JDK-8025979 that includes copyrights, 
>> invocation update and correct location in a specific "jni" folder.
>> I still need a sponsor for this fix, who can push it.
>>
>> Open webrev: http://cr.openjdk.java.net/~stsmirno/8025979/webrev.01/
>>
>> 21.04.2015 19:28, Stas Smirnov пишет:
>>> Hi Christian,
>>>
>>> talking about the invocation, in the original version I wanted to be 
>>> able to run all the tests even if one fails, catching the error, but 
>>> then I changed a logic a bit, however invocation remained the same, 
>>> thanks for catching this
>>> I will update the default switch-case statement and the @run argument.
>>>
>>> Talking about the naming, thanks for the information, in this case I 
>>> will put my new tests in runtime/JNI/UninitializedStrings folder and 
>>> another my fix in runtime/JNI/DefaultMethods
>>>
>>> 21.04.2015 18:32, Christian Tornqvist пишет:
>>>> Hi Stas,
>>>>
>>>> First of all, thanks for doing this.
>>>>
>>>> Is there a reason for not running all of the test cases in the same 
>>>> invocation of the test? This would save time when running the test. 
>>>> You could keep the ability to run an individual test but change the 
>>>> default switch statement to run all of them.
>>>>
>>>> Also, the test should not be in a folder named after the bug number 
>>>> (see 
>>>> https://wiki.openjdk.java.net/display/HotSpot/Naming+HotSpot+JTReg+Tests), 
>>>> I suggest you create a runtime/JNI folder for these tests.
>>>> Thanks,
>>>> Christian
>>>>
>>>> -----Original Message-----
>>>> From: hotspot-runtime-dev 
>>>> [mailto:hotspot-runtime-dev-bounces at openjdk.java.net] On Behalf Of 
>>>> Stas Smirnov
>>>> Sent: Monday, April 20, 2015 8:13 AM
>>>> To: hotspot-runtime-dev at openjdk.java.net
>>>> Subject: RFR(XS) 8025979: Write test to exercise uninitialized 
>>>> strings from JNI code
>>>>
>>>> Hello,
>>>>
>>>> Please review this fix for JDK-8025979. Also, I need a sponsor for 
>>>> this fix, who can push it.
>>>>
>>>> As a fix for JDK-8025979 a new set of tests has been developed to 
>>>> exercise uninitialized strings from JNI code.
>>>>
>>>> Open webrev: http://cr.openjdk.java.net/~stsmirno/8025979/webrev.00/
>>>> <http://cr.openjdk.java.net/%7Estsmirno/8025979/webrev.00/>
>>>>
>>>> JBS bug: https://bugs.openjdk.java.net/browse/JDK-8025979
>>>>
>>>> Tested: JPRT
>>>>
>>>
>>>
>>
>>
>> -- 
>>
>> Best regards,
>> Stas Smirnov
>>
>> Stas Smirnov | Java VM Runtime SQE
>> Phone: +7 812 3346130 | Mobile: +7 921 9262241
>> Oracle Development SPB, LLC
>> 10th Krasnoarmeyskaya 22A, St. Petersburg, 190103, Russia
>>
>