RFR (S): 8079091: Remove dictionary NULL check on common path of BlockFreeList methods
Kim Barrett
kim.barrett at oracle.com
Thu Apr 30 19:12:20 UTC 2015
On Apr 30, 2015, at 2:20 AM, David Holmes <david.holmes at oracle.com> wrote:
>
> On 30/04/2015 4:05 PM, Jungwoo Ha wrote:
>> http://cr.openjdk.java.net/~jwha/8079091/webrev.01
>
> I may be missing something but you seem to have embedded an object that is defined to be CHeapObj !
It's not clear to me whether deriving from CHeapObj *requires* heap
allocation or merely permits it. I would have guessed the latter,
based on actual usage for some of these allocation classes, but there
may be some reason I haven't spotted that would make heap allocation
required. The documentation seems to me to lean towards a requires
heap allocation interpretation. But there seem to be lots of places
where different allocation is used than what is stated by the base
class, which makes me think there are problems with what we have in
this area. But that should be a completely different discussion.
More information about the hotspot-runtime-dev
mailing list