RFR[ 9u-dev] JDK-8075773 - jps running as root fails after the fix of JDK-8050807

[Staffan Larsen]

Looks good!

/Staffan

> On 31 jul 2015, at 08:50, cheleswer sahu <cheleswer.sahu at oracle.com> wrote:
> 
> Hi,
> Thanks Dmitry and Jerry for your review comments. I have fixed the spacing and indentation issue.
> 
> Update web review link: http://cr.openjdk.java.net/~poonam/8075773/webrev.01/
> 
> Regards,
> Cheleswer
> 
> On 7/28/2015 3:13 AM, Gerald Thornbrugh wrote:
>> Hi Cheleswer,
>> 
>> Other than the issues Dimitry mentioned below your changes look good.
>> 
>> I am also not a "Reviewer".
>> 
>> Thanks!
>> 
>> Jerry
>>> Cheleswer,
>>> 
>>> src/os/linux/vm/perfMemory_linux.cpp
>>> 
>>> 220 space missed after //
>>> 222 space missed after !=
>>> 
>>> src/os/solaris/vm/perfMemory_solaris.cpp
>>> 
>>> 222 extra space before // (wrong indent)
>>> 
>>> Otherwise looks good. (not a Reviewer)
>>> 
>>> -Dmitry
>>> 
>>> 
>>> On 2015-07-27 20:07, cheleswer sahu wrote:
>>>> Hi,
>>>> 
>>>> Please review the code changes for
>>>> "https://bugs.openjdk.java.net/browse/JDK-8075773" .
>>>> Web review Link: http://cr.openjdk.java.net/~poonam/8075773/webrev.00/
>>>> 
>>>> Bug brief: This bug was introduced after the fix of JDK-8050807. JPS
>>>> reads the process information from
>>>> "/tmp/hsperfdata_$username_$ProcessID". In order to ensure the file is
>>>> secure to open and read, it tries to match the UID with the effective
>>>> user ID of that file. When JPS is run as root user this check gets failed.
>>>> 
>>>> Fix: If JPS is running as a root user, then the check which matches, UID
>>>> with effective user id is skipped.
>>>> 
>>>> I have test this fix, it's working fine and found no security issue.
>>>> 
>>>> 
>>>> Regards,
>>>> Cheleswer
>>> 
>> 
>