RFR (XS): JDK-8132953: imageDecompressor.hpp should not include precompiled.hpp

David Holmes david.holmes at oracle.com
Tue Aug 4 11:03:01 UTC 2015


Ship it! :)

Thanks,
David

On 4/08/2015 8:49 PM, Bengt Rutisson wrote:
>
> Hi David,
>
> Thanks for looking at this!
>
> On 2015-08-04 12:50, David Holmes wrote:
>> On 4/08/2015 8:31 PM, Bengt Rutisson wrote:
>>>
>>> Hi all,
>>>
>>> Could I have a couple of reviews for this cleanup of an include
>>> statement?
>>
>> I think one will suffice for such a trivial change.
>
> Sounds good to me. :)
>
>>
>>> .hpp files should not be including precompiled.hpp.
>>
>> Not only that but precompiled.hpp must be first in the include list.
>>
>> Which means:
>>
>> ./share/vm/classfile/imageDecompressor.cpp
>>
>> needs fixing.
>
> Good catch.
>
> Here's an updated webrev:
> http://cr.openjdk.java.net/~brutisso/8132953/webrev.01/
>
> Thanks,
> Bengt
>
>>
>> Thanks,
>> David
>> -----
>>
>>> http://cr.openjdk.java.net/~brutisso/8132953/webrev.00/
>>> https://bugs.openjdk.java.net/browse/JDK-8132953
>>>
>>> Thanks,
>>> Bengt
>>>
>>>
>>>
>


More information about the hotspot-runtime-dev mailing list