RFR XXS 8133537: clarify position of unlock options in error messages

Coleen Phillimore coleen.phillimore at oracle.com
Fri Aug 14 22:43:03 UTC 2015


This looks good, pending test results (there may be tests with the old 
error message as you say below).
Thanks,
Coleen

On 8/14/15 4:53 PM, Daniel D. Daugherty wrote:
> Greetings,
>
> I have a very small code review request to clarify the wording used
> when the following options are specified in the wrong place:
>
>     -XX:+UnlockDiagnosticVMOptions
>     -XX:+UnlockExperimentalVMOptions
>
> Even though this is a trivial change on the surface, we will not be
> following the HotSpot Trivial Change Rules. This means I need two
> reviewers and one must be a (R)eviewer.
>
> See the bug link for examples of the new output.
>
> 8133537: clarify position of unlock options in error messages
> https://bugs.openjdk.java.net/browse/JDK-8133537
>
> Webrev URL: 
> http://cr.openjdk.java.net/~dcubed/8133537-webrev/0-jdk9-hs-rt/
>
> Testing: JPRT -testset hotspot is in process
>          Aurora Adhoc Runtime-SVC Nightly testing (will be submitted 
> next)
>          (sanity check to make sure new error message line
>           does not break any tests)
>
> Thanks, in advance, for any comments, questions or suggestions.
>
> Dan



More information about the hotspot-runtime-dev mailing list