RFR(S): JDK-8133180 - [TESTBUG] runtime/SharedArchiveFile/SharedStrings.java failed with WhiteBox.class : no such file or directory

[Mikhailo Seledtsov]

Hi Jiangli,

  Thank you for your suggestion; it should make testing more robust.
I will try your suggestion; if I do not see any undesired side effects I 
will rerun full testset and re-submit the updated review.

Thank you,
Misha

On 8/14/2015 5:43 PM, Jiangli Zhou wrote:
> Hi Misha,
>
> I have one suggestion. Instead of searching either the ‘work’ or ‘classes’  directory depending on the ‘classesInWorkDir’ argument, how about searching both directories? So the BasicJarBuilder.build() method would use the ‘classes’ directory first, then try the ‘work’ directory if the file cannot be found in ‘classes'. That might be a more robust solution.
>
> Thanks,
> Jiangli
>
> On Aug 14, 2015, at 2:22 PM, Mikhailo Seledtsov <mikhailo.seledtsov at oracle.com> wrote:
>
>> Please review this fix to the CDS test bug. See the comments in the bug for details.
>>
>>     JBS: https://bugs.openjdk.java.net/browse/JDK-8133180
>>     Webrev: http://cr.openjdk.java.net/~mseledtsov/8133180.00/
>>     Testing:
>>         - ran the reproducer discussed in the bug description
>>             rm -Rf JT* test
>>             jtreg /media/data3/hg/9/work01/hs-rt/hotspot/test/testlibrary_tests/ctw/JarDirTest.java
>>             jtreg /media/data3/hg/9/work01/hs-rt/hotspot/test/runtime/SharedArchiveFile/SharedStrings.java
>>
>>         - ran the CDS tests in concurrent mode
>>         - running CDS tests via multi-platform build-and-test system
>>             (in progress)
>>
>> Thank you,
>> Misha