RFR(XS) 8133984) print_compressed_class_space() is only defined in 64-bit VM

[Vladimir Kozlov]

Thanks, Coleen

Vladimir

On 8/19/15 5:50 PM, Coleen Phillimore wrote:
>
> Ok.  That code should have been under ifdef _LP64.   Your change is fine.
> Coleen
>
>
> On 8/19/15 8:23 PM, Vladimir Kozlov wrote:
>> But then print_compressed_class_space will not be defined in 32 bit VM
>> and we will not be able to compile vmError.cpp.
>>
>> Vladimir
>>
>> On 8/19/15 4:48 PM, Coleen Phillimore wrote:
>>>
>>> Can you do:
>>>
>>> LP64_ONLY(*static void print_compressed_class_space(outputStream* st,
>>> const char* requested_addr = 0)__*_*;)*_
>>>
>>> instead so that we verify that it's not called unless under LP64?
>>>
>>> thanks and sorry, I think I caused this bug.
>>>
>>> Coleen
>>>
>>>
>>> On 8/19/15 7:26 PM, Vladimir Kozlov wrote:
>>>> http://cr.openjdk.java.net/~kvn/8133984/webrev/
>>>>
>>>> The call to Metaspace::print_compressed_class_space(st) in vmError.cpp
>>>> is not guarded by #ifdef _LP64. So some C++ compilers complain.
>>>>
>>>> I will push it into hs-comp.
>>>>
>>>> Thanks,
>>>> Vladimir
>>>
>