RFR (M) round 2 8061999 Enhance VM option parsing to allow options to be specified

[David Holmes]

On 29/08/2015 1:13 AM, Daniel D. Daugherty wrote:
> On 8/28/15 7:56 AM, Ron Durbin wrote:
>> Here is the round 2 webrev for 8061999.
>>
>> Due to the large number of conflicts with other bug fixes in the cmd
>> options
>> area and the resulting refactoring of this fix, a delta webrev is not
>> provided
>> relative to round 1 because it wouldn't make any sense.
>>
>> Webrev link: http://cr.openjdk.java.net/~rdurbin/8061999_OCR2_JDK9_webrev
>
> src/share/vm/runtime/arguments.hpp
>      No comments
>
> src/share/vm/runtime/arguments.cpp
>      Thanks for switching the buffer parse algorithm to be buffer length
>      terminated instead of relying on NULL termination. I think that
>      makes the algorithm more robust in terms of buffer overruns and
>      it should make dropping the OPTION_BUFFER_SIZE restriction in the
>      future easier.
>
>      L3757:       *flags_file = strdup(tail);
>          This should be 'os::strdup((char *)tail);'

When do these strdup'd values get freed? I couldn't keep track of the 
calling sequence.

Thanks,
David

>      L3843:   // If there's a VMOptionFile, parse that (also can set
> flags_file)
>          Typo: 'VMOptionFile' -> 'VMOptionsFile'
>
>
> Thumbs up modulo the two minor changes above. I don't need
> to see another webrev for just the above two changes.
>
> Dan
>
>
>>
>> RFE link: https://bugs.openjdk.java.net/browse/JDK-8061999
>>
>> This RFE allows a file to be specified that holds VM Options that
>> would otherwise be specified on the command line or in an environment
>> variable.
>> Only one options file may be specified on the command line and no
>> options file
>> may be specified in either of the following environment variables
>> "JAVA_TOOL_OPTIONS" or "_JAVA_OPTIONS".
>>
>> The options file feature supports all VM options currently supported on
>> the command line, except the options file option. The option to
>> specify an
>> options file is "-XX:VMOptionsFile=<Filename>".
>> The options file feature supports an options file up to 1024 bytes in
>> size,
>>
>> This feature has been tested on:
>>    OS:
>>      Solaris, MAC, Windows, Linux
>>    Tests:
>>      Manual unit tests
>>      JPRT with -testset hotspot (including the SQE proposed test
>> coverage for this feature.)
>>      Aurora,(Big Apps, JTREG,Tonga), Runtime SVC Nightly
>