8144223: Move j.l.invoke.{ForceInline, DontInline, Stable} to jdk.internal.vm.annotation package

Christian Thalinger christian.thalinger at oracle.com
Mon Dec 7 21:10:15 UTC 2015


> On Dec 2, 2015, at 11:11 AM, Paul Sandoz <Paul.Sandoz at oracle.com> wrote:
> 
>> 
>> On 2 Dec 2015, at 21:58, Mandy Chung <mandy.chung at oracle.com> wrote:
>> 
>> 
>>> On Nov 30, 2015, at 9:40 AM, Paul Sandoz <paul.sandoz at oracle.com> wrote:
>>> 
>>> Please review:
>>> 
>>> http://cr.openjdk.java.net/~psandoz/jdk9/JDK-8144223-move-stable-force-dont-inline-jdk/webrev/
>>> http://cr.openjdk.java.net/~psandoz/jdk9/JDK-8144223-move-stable-force-dont-inline-hotspot/webrev/
>> 
>> 
>> http://cr.openjdk.java.net/~psandoz/jdk9/JDK-8144223-move-stable-force-dont-inline-hotspot/webrev/src/jdk.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/Stable.java.cdiff.html
>> 
>> 32  * This annotation functions as an alias for the jdk.internal.Stable annotation within JVMCI
>> 
>> s/jdk.internal.Stable/jdk.internal.vm.annotation.Stable
>> 
>> http://cr.openjdk.java.net/~psandoz/jdk9/JDK-8144223-move-stable-force-dont-inline-jdk/webrev/src/java.base/share/classes/java/lang/invoke/InvokerBytecodeGenerator.java.frames.html
>> 
>> 1327         mv.visitAnnotation("Ljdk/internal/DontInline;", true);
>> 
>> need fixing.
>> 
> 
> Oops that’s embarrassing, i fat fingered the search/replace. Our tests don’t catch such cases of non-existent annotations.

I never liked the fact that we are using hardcoded strings here.  Getting the name from the class would be better.

> 
> Updated, thanks,
> Paul.
> 
> 
>> Otherwise, looks good.
>> 
>> Mandy



More information about the hotspot-runtime-dev mailing list