RFR: 8144885: agent/src/os/linux/libproc.h needs to support Linux/SPARC builds

David Holmes david.holmes at oracle.com
Tue Dec 8 05:23:29 UTC 2015


On 8/12/2015 2:59 PM, Gerald Thornbrugh wrote:
> Hi David,
>
> Yes, I believe this is a devkit issue.  Mikael and I have been working
> to get JDK9 building
> in JPRT with the lab Linux/SPARC machines that use a devkit and this
> change was needed.
> I will update the bug detailing this as a devkit issue.

In which case the devkit needs fixing I think, not the code.

Cheers,
David

> Thanks!
>
> Jerry
>> Hi Jerry,
>>
>> On 8/12/2015 8:58 AM, Gerald Thornbrugh wrote:
>>> Hi Everyone,
>>>
>>> Please review this small change which fixes a JDK9 Linux/SPARC build
>>> problem in "hotspot/agent/src/os/linux/libproc.h”
>>> so the correct “ptrace.h” include file will be used during the build
>>> process.
>>>
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8144885
>>> <https://bugs.openjdk.java.net/browse/JDK-8144885>
>>> Webrev: http://cr.openjdk.java.net/~gthornbr/8144885/webrev/
>>> <http://cr.openjdk.java.net/~gthornbr/8144885/webrev/>
>>
>> As far as I can see both versions of ptrace.h exist on linux x86 and
>> linux sparc distributions, so it is not at all clear why this change
>> is needed. Is it perhaps an issue with a devkit?
>>
>> Thanks,
>> David
>>
>>> Thanks,
>>>
>>> Jerry
>>>
>


More information about the hotspot-runtime-dev mailing list