RFR(S): JDK-8145317 ReservedStackTest fails with ReentrantLock looks corrupted

Daniel D. Daugherty daniel.daugherty at oracle.com
Wed Dec 16 15:35:32 UTC 2015


On 12/16/15 5:11 AM, Frederic Parain wrote:
> Please review this small fix in ReservedStackTest test.
> The test didn't exclude correctly some platforms where
> the feature is not supported. The logic has been changed
> to explicitly list the supported platforms.
>
> CR: https://bugs.openjdk.java.net/browse/JDK-8145317
>
> Webrev: http://cr.openjdk.java.net/~fparain/8145317/webrev/

test/runtime/ReservedStack/ReservedStackTest.java
     L27:  * @build ReservedStackTest
         I'm reasonably certain that the @run line takes care of
         building ReservedStackTest. What I meant by my comment
         in the bug is that you need:

         @build jdk/test/lib/Platform

         or something like it. David H is the guy to ask for
         what you need to build in the library stuff.

     L202:                 System.exit(-1);
         I missed this in my original review of the test. Why
         use '-1' for the test exit code. For JTREG tests, I
         typically see '1' or some other small positive integer.
         Feel free to ignore this comment since any non-zero
         should work.

Dan


>
> Tested with JPRT, testset hotspot with aarch64 platform manually
> added to the target platforms list.
>
> Thanks,
>
> Fred
>



More information about the hotspot-runtime-dev mailing list