RFR: 8144874: Reimplement TraceClassResolution with UL

Ioi Lam ioi.lam at oracle.com
Wed Dec 16 23:27:31 UTC 2015


Hi Max,

[1] I think you need to rebase your changes and send out a new webrev. 
The latest version of argument.cpp already has these

static AliasedFlag const aliased_jvm_logging_flags[] = {
   { "-XX:+TraceMonitorInflation", "-Xlog:monitorinflation=debug" },
   { "-XX:-TraceMonitorInflation", "-Xlog:monitorinflation=off" },
   { NULL, NULL }
};

which would conflict with similar lines that you added.

[2] In the test case ClassResolutionTest.java:

Is there any need for adding "-Xmx64m"? If not, I think it should be 
removed.

[3] Also, could you send out a sample log that covers all of the 
different logging lines that you have touched?

I think the "RESOLVE" in the following output is redundant and should be 
removed.

[classresolve] RESOLVE 
ClassResolutionTest$ClassResolutionTestMain$Thing1Handler 
ClassResolutionTest$ClassResolutionTestMain$Thing1

Thanks
- Ioi

On 12/16/15 12:44 PM, Max Ockner wrote:
> Hello all,
> Please review my code for another Unified Logging conversion.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8144874
> Webrev: http://cr.openjdk.java.net/~mockner/classresolve/
>
> Summary: "-XX:+TraceClassResolution" reimplemented using Unified 
> Logging with classresolve tag and Info level. Support is maintained 
> for TraceClassResolution using the alias table.
>
> Tested with: Selection Resolution tests, jtreg tests. This change also 
> adds a jtreg test for the implementation of classresolve, and for the 
> maintained support of TraceClassResolution.
>
> Thanks,
> Max



More information about the hotspot-runtime-dev mailing list