RFR(S): JDK-8145317 ReservedStackTest fails with ReentrantLock looks corrupted

Frederic Parain frederic.parain at oracle.com
Fri Dec 18 10:13:17 UTC 2015


Karen,

Thank you for the review.

Fred

On 12/17/2015 09:54 PM, Karen Kinnear wrote:
> Fix looks good. Thank you for doing all the requested changes.
>
> thanks,
> Karen
>
>> On Dec 17, 2015, at 3:29 PM, Frederic Parain <frederic.parain at oracle.com> wrote:
>>
>> Here's a new webrev:
>> http://cr.openjdk.java.net/~fparain/8145317/webrev.01/
>>
>> Call to System.exit() has been removed.
>>
>> The new version has been tested with JPRT on all platforms
>> including aarch64.
>>
>> I have another JPRT job running with the feature disabled
>> to check if the failure is detected correctly. So far,
>> it has been successfully detected on MacOSX and Solaris
>> platforms, Linux targets have not been run yet.
>>
>> Thanks,
>>
>> Fred
>>
>> On 17/12/2015 15:10, Christian Tornqvist wrote:
>>> Hi Frederic,
>>>
>>> You're not allowed to do System.exit() in a jtreg test, please change the test to simply return.
>>>
>>> Thanks,
>>> Christian
>>>
>>> -----Original Message-----
>>> From: hotspot-runtime-dev [mailto:hotspot-runtime-dev-bounces at openjdk.java.net] On Behalf Of Frederic Parain
>>> Sent: Wednesday, December 16, 2015 7:12 AM
>>> To: hotspot-runtime-dev at openjdk.java.net
>>> Subject: RFR(S): JDK-8145317 ReservedStackTest fails with ReentrantLock looks corrupted
>>>
>>> Please review this small fix in ReservedStackTest test.
>>> The test didn't exclude correctly some platforms where the feature is not supported. The logic has been changed to explicitly list the supported platforms.
>>>
>>> CR: https://bugs.openjdk.java.net/browse/JDK-8145317
>>>
>>> Webrev: http://cr.openjdk.java.net/~fparain/8145317/webrev/
>>>
>>> Tested with JPRT, testset hotspot with aarch64 platform manually added to the target platforms list.
>>>
>>> Thanks,
>>>
>>> Fred
>>>
>>> --
>>> Frederic Parain - Oracle
>>> Grenoble Engineering Center - France
>>> Phone: +33 4 76 18 81 17
>>> Email: Frederic.Parain at oracle.com
>>>
>>
>> --
>> Frederic Parain - Oracle
>> Grenoble Engineering Center - France
>> Phone: +33 4 76 18 81 17
>> Email: Frederic.Parain at oracle.com
>

-- 
Frederic Parain - Oracle
Grenoble Engineering Center - France
Phone: +33 4 76 18 81 17
Email: Frederic.Parain at oracle.com


More information about the hotspot-runtime-dev mailing list