RFR(M): 8048521 - Remove obsolete code from os_windows.cpp/hpp

Ron Durbin ron.durbin at oracle.com
Mon Dec 21 15:00:27 UTC 2015


Christian,

Cleanup changes look good.

Ron

>-----Original Message-----
>From: Christian Tornqvist
>Sent: Monday, December 21, 2015 5:18 AM
>To: hotspot-runtime-dev at openjdk.java.net
>Subject: RFR(M): 8048521 - Remove obsolete code from os_windows.cpp/hpp
>
>Hi everyone,
>
>
>
>Please review this change that removes a lot of obsolete code from
>os_windows.cpp/hpp and related files. Changes include:
>
>
>
>*         Remove is_nt() check and dead code related to it
>
>*         Remove win32::__has_performance_count() and related dead code
>since the MSDN page for QueryPerformanceFrequency says: "On systems that run
>Windows XP or later, the function will always succeed and will thus never
>return zero."
>
>*         Remove the check for API's that are always present in all our
>supported Windows versions
>
>
>
>Webrev:
>
>http://cr.openjdk.java.net/~ctornqvi/webrev/8048521/webrev.00/
>
>
>
>Bug:
>
>https://bugs.openjdk.java.net/browse/JDK-8048521
>
>
>
>Change was tested on Windows 32/64-bit using
>hotspot/test/:hotspot_all,jdk/test/:tier1,jdk/test/:tier2
>
>
>
>Thanks,
>
>Christian
>


More information about the hotspot-runtime-dev mailing list