RFR: 8144874: Reimplement TraceClassResolution with UL

Ioi Lam ioi.lam at oracle.com
Tue Dec 22 03:08:59 UTC 2015


Hi Max,

Your changes look good.

There's no need to add @build for the java.lang.ref.WeakReference and 
java.lang.ref.WeakReference, because they are already in the JDK. You 
only need to add @build for classes that comes in source form from under 
any of the directories specified by @library.

Thanks
- Ioi

On 12/21/15 2:13 PM, Max Ockner wrote:
> I have addressed all of these concerns except for the additions to my 
> @build line. The test can't find the additional modules, and it breaks 
> unless I leave the @build line as is.
> webrev: http://cr.openjdk.java.net/~mockner/classresolve/
> Thanks,
> Max
>
> On 12/17/2015 12:36 PM, Rachel Protacio wrote:
>>
>> test/runtime/logging/ClassResolutionTest.java
>>
>>    You probably need to add "java.lang.ref.WeakReference" and
>>    "java.lang.reflect.Method" to the @build line, but there seems to be
>>    some debate about that going on in my 8145445 RFR thread right now.
>>    But you'll probably need it.



More information about the hotspot-runtime-dev mailing list