RFR(S): 8144923 - Remove Windows IA64 code

[Lindenmaier, Goetz]

Thanks!
  
Best regards,
  Goetz.

> -----Original Message-----
> From: Christian Tornqvist [mailto:christian.tornqvist at oracle.com]
> Sent: Dienstag, 22. Dezember 2015 14:31
> To: Lindenmaier, Goetz <goetz.lindenmaier at sap.com>; hotspot-runtime-
> dev at openjdk.java.net
> Subject: RE: RFR(S): 8144923 - Remove Windows IA64 code
> 
> Hi Goetz,
> 
> Ok, I'll leave the Windows IA64 code in there. I'm hereby withdrawing this
> review.
> 
> Thanks,
> Christian
> 
> -----Original Message-----
> From: Lindenmaier, Goetz [mailto:goetz.lindenmaier at sap.com]
> Sent: Tuesday, December 8, 2015 10:55 AM
> To: Christian Tornqvist <christian.tornqvist at oracle.com>;
> hotspot-runtime-dev at openjdk.java.net
> Subject: RE: RFR(S): 8144923 - Remove Windows IA64 code
> 
> Hi,
> 
> actually, we are using this code.  We have a windows ia64 port based on
> jdk9.
> So we would appreciate if the changes in os_windows.cpp would stay in
> there.
> The fix in oop.inline.hpp seems superfluous, and is wrong anyways, see
> below.
> So we wouldn't object to removing that.
> 
> Reviewed wrt. to this comment.
> 
> Best regards,
>   Goetz.
> 
> 
> 
> 
> 
> There is a small nit with the change in oop.inline.hpp, the pointer is not
> dereferenced.
> diff -r 7f94410f8fb3 src/share/vm/oops/oop.inline.hpp
> --- a/src/share/vm/oops/oop.inline.hpp  Tue Dec 08 15:32:26 2015 +0100
> +++ b/src/share/vm/oops/oop.inline.hpp  Tue Dec 08 16:35:07 2015 +0100
> @@ -415,7 +415,7 @@
>                            arrayOopDesc::length_offset_in_bytes() );
>        assert(array_length > 0, "Integer arithmetic problem somewhere");
>        // Put into size_t to avoid overflow.
> -      size_in_bytes = (size_t) array_length;
> +      size_in_bytes = (size_t) *array_length;
>        size_in_bytes = size_in_bytes <<
> Klass::layout_helper_log2_element_size(lh);
>  #else
>        size_t array_length = (size_t) ((arrayOop)this)->length();
> 
> 
> 
> > -----Original Message-----
> > From: hotspot-runtime-dev [mailto:hotspot-runtime-dev-
> > bounces at openjdk.java.net] On Behalf Of Christian Tornqvist
> > Sent: Dienstag, 8. Dezember 2015 15:43
> > To: hotspot-runtime-dev at openjdk.java.net
> > Subject: RFR(S): 8144923 - Remove Windows IA64 code
> >
> > Hi everyone,
> >
> >
> >
> > Please review this small change that removes code for Windows on IA64.
> >
> >
> >
> > Webrev:
> >
> > http://cr.openjdk.java.net/~ctornqvi/webrev/8144923/webrev.00/
> >
> >
> >
> > Bug:
> >
> > https://bugs.openjdk.java.net/browse/JDK-8144923
> >
> >
> >
> > Thanks,
> >
> > Christian
>