RFR - 8072450: 9-dev build failed on elinux-i586 and rlinux-i586

[Daniel Fuchs]

On 04/02/15 14:58, Coleen Phillimore wrote:
>
> I just hit this error in a linux 32 bit machine I'm testing.  The change
> looks good.   It looks like you're going to check this into hs-rt - that
> would be great.

Hi Colleen,

Thanks for reviewing :-)

I've been instructed by Alejandro to push it directly manually to
jdk9/dev after running a control job.

So it's going to go in jdk9/dev.

best regards,

-- daniel

>
> Thanks,
> Coleen
>
> On 2/4/15, 6:44 AM, David Holmes wrote:
>> Reviewed!
>>
>> Just to clarify for others - only nightly builds seem to be affected
>> by this due to use of very old gcc version. So developers should be
>> unlikely to see this. JPRT is not affected.
>>
>> Thanks,
>> David
>>
>> On 4/02/2015 9:31 PM, Daniel Fuchs wrote:
>>> Hi,
>>>
>>> Please find below a fix for:
>>>
>>> 8072450: 9-dev build failed on elinux-i586 and rlinux-i586
>>>
>>> My fix for JDK-8068730 which was integrated from hs-rt into jdk9-dev
>>> yesterday is causing a build failure in the jdk9/dev nightly on two
>>> platforms.
>>> It appears that these platforms have a slightly older version
>>> of the compiler - which chokes on jvm.cpp with the following error:
>>>
>>> hotspot/src/share/vm/prims/jvm.cpp:307: error: integer constant is too
>>> large for ���long��� type
>>>
>>> Adding a LL suffix should solve the issue:
>>>
>>> ##############
>>>
>>> diff --git a/src/share/vm/prims/jvm.cpp b/src/share/vm/prims/jvm.cpp
>>> --- a/src/share/vm/prims/jvm.cpp
>>> +++ b/src/share/vm/prims/jvm.cpp
>>> @@ -304,7 +304,7 @@
>>>   // java.lang.System, but we choose to keep it here so that it stays
>>> next
>>>   // to JVM_CurrentTimeMillis and JVM_NanoTime
>>>
>>> -const jlong MAX_DIFF_SECS = 0x0100000000;   //  2^32
>>> +const jlong MAX_DIFF_SECS = 0x0100000000LL; //  2^32
>>>   const jlong MIN_DIFF_SECS = -MAX_DIFF_SECS; // -2^32
>>>
>>>   JVM_LEAF(jlong, JVM_GetNanoTimeAdjustment(JNIEnv *env, jclass ignored,
>>> jlong offset_secs))
>>>
>>> ##############
>>>
>>> ( or if you prefer here is a webrev:
>>>    http://cr.openjdk.java.net/~dfuchs/webrev_8072450/webrev.00 )
>>>
>>> best regards,
>>>
>>> -- daniel
>>>
>