RFR (XS) JDK-8072694: Need errno info when CDS archive creation fails

[harold seigel]

Hi David,

Thanks for the review.

Harold

On 2/9/2015 8:29 PM, David Holmes wrote:
> On 9/02/2015 11:05 PM, Lois Foltan wrote:
>> Hi Harold,
>>
>> Looks good.  Really minor comment:
>>
>>    src/share/vm/memory/filemap.cpp:
>>        - line #391  - you might want to format the error message
>> consistently with
>>          how it is formatted in FileMapInfo::open_for_read(). In that
>> method the
>>          errno info is put in parentheses.  I don't have a preference
>> for either format
>>          just that both formats are consistent.
>>
>> I don't need to see a new webrev.
>
> +1
>
> Thanks,
> David
> -----
>
>
>> Thanks,
>> Lois
>>
>> On 2/9/2015 7:42 AM, harold seigel wrote:
>>> Hi,
>>>
>>> Please review this small fix for bug 8072694.
>>>
>>> Open webrev: http://cr.openjdk.java.net/~hseigel/bug_8072694_errno/
>>>
>>> JBS bug: https://bugs.openjdk.java.net/browse/JDK-8072694
>>>
>>> The fix was regression tested with JPRT, JCK lang and VM tests,
>>> hotspot JTReg, and NSK quick tests. In addition, I ran tests that
>>> intentionally failed to create the archive and checked the generated
>>> errno messages.
>>>
>>> Thanks, Harold
>>