RFR 8054494: Remove sun.misc.Unsafe.monitorEnter, monitorExit and tryMonitorEnter
Paul Sandoz
paul.sandoz at oracle.com
Fri Jan 9 15:52:55 UTC 2015
Hi,
http://cr.openjdk.java.net/~psandoz/jdk9/JDK-8054494-dev-unsafe-monitor-remove/webrev/
This "forest" webrev [*] removes the monitor related methods from Unsafe.
The temptation to cleanup code in unsafe.cpp was resisted. I gather now that HotSpot Express no longer exists the grouping of registered native methods can be cleaned up plus there is dead code related to prefetch support. I propose to cleanup in a future patch.
The monitor methods resurface on WhiteBox because i noticed some associated Unsafe usages within hotspot Java tests. Rather than attempting to change such tests i thought it better to move the existing functionality.
Now that WhiteBox has moved to the top level repository i could update ProcessBuilder/Basic.java to use WhiteBox. I held off doing that for now (it seems a little involved to get the relevant classes on the classpath for the executing tests with such a dependency).
A JPRT job using the hotspot testset passed. Is that the correct testset to use?
Thanks,
Paul.
[*] Unfortunately "webrev -f" does not create a patch per repo as listed by "hg tlist".
More information about the hotspot-runtime-dev
mailing list